enable proxy for remaining clients #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshw123
approved these changes
Feb 21, 2024
|
I don't think this was necessary. It was required in #145, as you were providing a Transport object. imo, it's better to leave it as nil so that you're sure to retain the other characteristics of DefaultTransport. |
aidy
added a commit
to aidy/version-checker
that referenced
this pull request
Mar 7, 2024
This reverts commit 293835e. It's unnecessary to specify ProxyFromEnvironment in these cases. It was required for the selfhosted client, as we are overriding the default Transport object. In these cases, Transport are nil, and so should default to DefaultTransport: https://cs.opensource.google/go/go/+/refs/tags/go1.22.0:src/net/http/client.go;l=60 This already has ProxyFromEnvironment as the default behaviour: https://github.com/golang/go/blob/master/src/net/http/transport.go#L44 As this is unnecessary, it's better to leave it undefined to ensure that the other characteristics of DefaultTransport are retained.
aidy
added a commit
that referenced
this pull request
Mar 8, 2024
This reverts commit 293835e. It's unnecessary to specify ProxyFromEnvironment in these cases. It was required for the selfhosted client, as we are overriding the default Transport object. In these cases, Transport are nil, and so should default to DefaultTransport: https://cs.opensource.google/go/go/+/refs/tags/go1.22.0:src/net/http/client.go;l=60 This already has ProxyFromEnvironment as the default behaviour: https://github.com/golang/go/blob/master/src/net/http/transport.go#L44 As this is unnecessary, it's better to leave it undefined to ensure that the other characteristics of DefaultTransport are retained.
davidcollom
added a commit
that referenced
this pull request
Mar 22, 2024
Co-authored-by: David Collom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the back of #145 this add's support for the remaining Clients as there may be proxies across the entire environment