Fix: docker hub images if they have no timestamp #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcollom
force-pushed
the
issue-123
branch
from
ce1d239 to
661e96f
Compare
davidcollom
force-pushed
the
issue-123
branch
from
efaf503 to
9422de6
Compare
davidcollom
force-pushed
the
issue-123
branch
from
9422de6 to
0b188e4
Compare
joshw123
approved these changes
Nov 2, 2023
|
LGTM! :) |
davidcollom
changed the title
|
Thank you @davidcollom ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions, the docker hub repository doesn't have the date in whcih the image was pushed, therefore resulting in version-checker not monitoring the image what so ever.
This changes the logic some what for docker hub repositories as if the timestamp is missing we default to the Unix Timestamp in the hope that SemVer checking takes precidence.
The likely hood of these images without timestamps being the latest is highly unlikely or there's a data integrity issue with the repository its self.
Resolves #123