Skip to content

Commit

Permalink
Don't take curl callback by ref
Browse files Browse the repository at this point in the history
Changing these does nothing to the caller, why would you take them by ref? HHVM doesn't promote this to refs if they can't be modified: facebook/hhvm#2587
  • Loading branch information
ptarjan committed May 15, 2014
1 parent 7cce95a commit 1a33bb8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion S3.php
Original file line number Diff line number Diff line change
Expand Up @@ -2307,7 +2307,7 @@ private function __dnsBucketName($bucket)
* @param string &$data Data
* @return integer
*/
private function __responseHeaderCallback(&$curl, &$data)
private function __responseHeaderCallback($curl, $data)
{
if (($strlen = strlen($data)) <= 2) return $strlen;
if (substr($data, 0, 4) == 'HTTP')
Expand Down

0 comments on commit 1a33bb8

Please sign in to comment.