fix: for #6374 to delete non-empty directories #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellersj
changed the title
|
Thank you for reporting and fixing the issue. Really appreciate this. |
| @@ -91,7 +91,10 @@ public static boolean delete(@Nullable File file) { | |||
| } | |||
|
|
|||
| try { | |||
| Files.delete(file.toPath()); | |||
| Files.walk(file.toPath()) | |||
There was a problem hiding this comment.
The stream returned by Files.walk should be closed.
There was a problem hiding this comment.
Interesting... most streams don't need to be closed like this; as documented in the Stream javadoc. Hadn't thought about this possibly being tied to an IO channel. Turns out this isn't uncommon: https://sourcegraph.com/search?q=context:global+content:%22try+%28Stream%3CPath%3E+paths+%3D+Files.walk%28%22+lang:java&patternType=standard&sm=1&groupBy=repo
Fixed with #6382
Thanks!
This was referenced Jan 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6374
Description of Change
Walk the files to delete using just java.
Have test cases been added to cover the new functionality?
yes