Merge pull request #841 from timja/use-inline-elements

Use inline elements on run summary page
jenkinsci · Mar 8, 2021 · 5e4a74c · 5e4a74c
2 parents 55a085f + de318c6
commit 5e4a74c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/StaticAnalysisLabelProvider.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/StaticAnalysisLabelProvider.java
@@ -234,7 +234,7 @@ public String getLargeIconUrl() {
      */
     public ContainerTag getTitle(final AnalysisResult result, final boolean hasErrors) {
         String icon = hasErrors ? ERROR_ICON : INFO_ICON;
-        return div(join(getName() + ": ",
+        return span(join(getName() + ": ",
                 getWarningsCount(result),
                 a().withHref(getId() + "/info").with(
                         new UnescapedText(new SvgTag(icon, jenkins).withClasses("info-page-decorator").render())))).withId(

diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/Summary.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/Summary.java
@@ -66,7 +66,7 @@ public Summary(final StaticAnalysisLabelProvider labelProvider, final AnalysisRe
      * @return the summary
      */
     public String create() {
-        return div(labelProvider.getTitle(analysisResult, !analysisResult.getErrorMessages().isEmpty()),
+        return span(labelProvider.getTitle(analysisResult, !analysisResult.getErrorMessages().isEmpty()),
                 createDescription())
                 .withId(labelProvider.getId() + "-summary")
                 .renderFormatted();

diff --git a/plugin/src/test/java/io/jenkins/plugins/analysis/core/model/SummaryTest.java b/plugin/src/test/java/io/jenkins/plugins/analysis/core/model/SummaryTest.java
@@ -83,7 +83,7 @@ void shouldHaveCorrectIDsForDivs() {
         AnalysisResult analysisResult = createAnalysisResult(EMPTY_ORIGINS, 0, 0,
                 EMPTY_ERRORS, 0);
         String createdHtml = createSummary(analysisResult).create();
-        assertThat(createdHtml).contains("<div id=\"test-summary\">");
+        assertThat(createdHtml).contains("<span id=\"test-summary\">");
         assertThat(createdHtml).contains("id=\"test-title\"");
     }