Skip to content

Commit

Permalink
Use plugin bom version prior to trilead API upgrade (#212)
Browse files Browse the repository at this point in the history
The plugin compatibility tester mistakenly uses the version of optional
plugins that is provided by the pom of the tested plugin rather than
using the version of plugin that is listed in the pom file of the plugin
bill of materials.

Because of that issue, the 2.426.x plugin bill of materials version
needs to remain on an older version in order to not include an optional
dependency on a newer version of the trilead API plugin.

3080.vfa_b_e4a_a_39b_44 is the version immediately before a trilean API
plugin upgrade in the BOM.

jenkinsci/bom#3404 has more details

#211 includes
some discussion as well.
  • Loading branch information
MarkEWaite authored Jul 26, 2024
1 parent e5af1db commit 884f71d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.426.x</artifactId>
<version>3208.vb_21177d4b_cd9</version>
<!-- Last 2.426.x BOM version before a trilead api upgrade -->
<!-- Trilead API upgrade breaks plugin compatibility tests due to poor handling of optional dependencies -->
<!-- Do not change this without checking plugin BOM passes with new version -->
<!-- https://github.com/jenkinsci/bom/pull/3404 -->
<version>3080.vfa_b_e4a_a_39b_44</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down

0 comments on commit 884f71d

Please sign in to comment.