Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding potential deadlock in counting number of builds #718

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Avoiding potential deadlock in counting number of builds #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/main/java/org/jenkinsci/plugins/prometheus/collectors/jobs/NbBuildsGauge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
import io.prometheus.client.SimpleCollector;
import org.jenkinsci.plugins.prometheus.collectors.CollectorType;
import org.jenkinsci.plugins.prometheus.collectors.builds.BuildsMetricCollector;

import java.util.concurrent.locks.ReentrantReadWriteLock;

public class NbBuildsGauge extends BuildsMetricCollector<Job<?, ?>, Gauge> {

private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();

protected NbBuildsGauge(String[] labelNames, String namespace, String subsystem) {
super(labelNames, namespace, subsystem);
}
Expand All @@ -30,7 +32,12 @@ protected SimpleCollector.Builder<?, Gauge> getCollectorBuilder() {

@Override
public void calculateMetric(Job<?, ?> jenkinsObject, String[] labelValues) {
int nbBuilds = jenkinsObject.getBuildsAsMap().size();
this.collector.labels(labelValues).set(nbBuilds);
lock.readLock().lock();
try {
int nbBuilds = jenkinsObject.getBuildsAsMap().size();
this.collector.labels(labelValues).set(nbBuilds);
} finally {
lock.readLock().unlock();
}
}
}
Loading