This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Make PMD cutoff levels configurable #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making the mapping configurable! The PMD parser (and the associated plugin) has been integrated into the warnings plugin (see PMD tool descriptor). These changes are not yet released but I don't think that it makes sense to add any new functionality to the PMD plugin. It would make more sense to adapt your changes to the new API. What do you think? The FindBugs tool descriptor shows how to provide additional properties... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using jenkins as part of our internal build process and we recently decided to change the meanings of the PMD levels for our build. To make a long story short, we consider both 4 and 5 to be "low priority". However, it turns out that the Jenkins plugin for collecting PMD information has the mapping "1,2" -> HIGH, "3,4" -> NORMAL, "5" -> LOW hard coded.
This patch adds new configuration for both the PMD Reporter and the PMD Publisher to make the cutoffs for "HIGH" and "NORMAL" configurable. The defaults are the same as the hard coded values from the current plugin, so upgrading to this change should not change any behavior.