Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add Year to Job Run Timestamp in pipeline-stage-view-plugin #347

Merged

Conversation

DeepData-Diver
Copy link
Contributor

@DeepData-Diver DeepData-Diver commented Sep 4, 2024

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@DeepData-Diver DeepData-Diver requested a review from a team as a code owner September 4, 2024 02:19
@DeepData-Diver
Copy link
Contributor Author

Addressed this Jenkins issue: https://issues.jenkins.io/browse/JENKINS-73507

jglick
jglick previously requested changes Sep 4, 2024
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be aware that this plugin is generally not maintained.

pom.xml Outdated Show resolved Hide resolved
pom.xml.versionsBackup Outdated Show resolved Hide resolved
ui/src/main/js/view/templates/index.js Outdated Show resolved Hide resolved
@jglick
Copy link
Member

jglick commented Sep 16, 2024

I am not sure this is a net benefit; it breaks the layout a bit.

Chrome before

Screenshot from 2024-09-16 12-22-16

and after

Screenshot from 2024-09-16 12-23-01

and Firefox before

Screenshot 2024-09-16 at 12-27-05 x Jenkins

and after

Screenshot 2024-09-16 at 12-27-13 x Jenkins

@jglick
Copy link
Member

jglick commented Sep 16, 2024

Note that the issue suggests showing the year only if the build is more than a year old, which seems prudent. (Or a few months old at least. For that matter, maybe we should display the day only if the build is more than a few hours old. Otherwise the time would suffice.)

@DeepData-Diver
Copy link
Contributor Author

Addressed PR comments. Please see new changes. Here is a sample image that illustrates changes:
image

@jglick jglick requested a review from a team October 2, 2024 11:42
@DeepData-Diver
Copy link
Contributor Author

@jglick Please review PR. Thanks

@DeepData-Diver
Copy link
Contributor Author

Hello, just checking to see if more changes are required for this PR?

@jglick jglick removed their request for review November 25, 2024 23:00
@jglick
Copy link
Member

jglick commented Nov 25, 2024

Did not check; nobody maintains this plugin.

@olamy
Copy link
Member

olamy commented Nov 25, 2024

let's get this merged

@olamy olamy merged commit 5c5b880 into jenkinsci:master Nov 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants