Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-72386: replace --no-transfer-progress option #744

Closed
wants to merge 1 commit into from

Conversation

cronik
Copy link
Contributor

@cronik cronik commented Dec 5, 2023

-ntp is not supported on versions of maven prior to 3.6.1. Maven does exits with "unrecognized option" when it encounters an option it doesn't know about.

This solution uses replaces the unsupported option with a system property to reduce the transfer logger used for batch mode to WARN only. See MRELEASE-1048

Fixes JENKINS-72386 introduced by #716

Testing done

Tested 3.6 and 3.9 does not output transfer logs with alternate setting.

Submitter checklist

Preview Give feedback

@cronik cronik requested a review from a team as a code owner December 5, 2023 17:41
-ntp is not supported on versions of maven prior to 3.8. Maven does
exits with "unrecognized option" when it encounters an option it
doesn't know about.

This solution uses replaces the unsupported option with a system
property to reduce the transfer logger used for batch mode to WARN
only. See [MRELEASE-1048](https://issues.apache.org/jira/browse/MRELEASE-1048)
@cronik cronik force-pushed the bugfix/JENKINS-72386 branch from 1210382 to 598a778 Compare December 6, 2023 14:17
@cronik
Copy link
Contributor Author

cronik commented Dec 7, 2023

@bguerin any chance this PR can be adopted in place of --no-progress-transfer? it has the same out outcome and is backwards compatible.

@bguerin
Copy link
Contributor

bguerin commented Jan 1, 2024

Hello @cronik

Thanks for your work. I did not expect to still have to deal with more than 4 years old Maven versions (3.6.1 was out on april 2019).
I will not follow this way as it uses internals of Maven. Quoting maven-release-plugin is not an argument from my point of view. The release plugin and Maven are the same project, they share parts of code, and maintainers of one can act on other if needed.

This Jenkins plugin is just using Maven, as you could do by hand in a scripted Jenkinsfile. I do not want to depend on internals of Maven, which could change or disappear.

I also have to solve some Jenkins CI issues if I want to upgrade to Maven 3.9 (handle MAVEN_ARGS env var), so I will close this PR in favor of another solution:
#749

@bguerin bguerin closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants