forked from geoffbullen/build-pipeline-plugin
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73960] Extract event handlers in BuildCardExtension/buildCardTemplate.jelly
#142
Open
shlomomdahan
wants to merge
26
commits into
jenkinsci:master
Choose a base branch
from
shlomomdahan:JENKINS-73960
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomomdahan
changed the title
[JENKINS-73960]
[JENKINS-73960] Extract event handlers in Oct 23, 2024
BuildCardExtension/buildCardTemplate.jelly
...ems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
Outdated
Show resolved
Hide resolved
...ems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
Outdated
Show resolved
Hide resolved
shlomomdahan
commented
Oct 30, 2024
...trumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly
Show resolved
Hide resolved
6 tasks
This was referenced Oct 31, 2024
shlomomdahan
force-pushed
the
JENKINS-73960
branch
from
November 7, 2024 19:35
c8e65c6
to
7beca34
Compare
...ems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
Outdated
Show resolved
Hide resolved
...ems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
Outdated
Show resolved
Hide resolved
...ems/hudson/plugin/buildpipeline/extension/BuildCardExtension/build-card-template-onclicks.js
Outdated
Show resolved
Hide resolved
yaroslavafenkin
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73960
Testing done
Line 64
Setup Instructions: Jenkins Build Pipeline
1. Create Two Freestyle Projects:
2. Configure the Upstream Project:
Downstream
in the Projects to build field.3. Create a Build Pipeline View:
4. Run the Pipeline:
5. Check the Progress:
Line 97
Same as above +
1. Add Parameterized Values
Line 109
Same as above +
downstream2
upstream
post-build actionsLine 118
Same as above +
exit 1
to trigger a failureLine 125
ProjectUtil.java
Line 129
Same as above +
exit 1
so the build fails.Line 140
Line 145
Same as line 140 but use below settings for Pipeline View Configuration
Submitter checklist