Refresh plugin for October 2024 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
force-pushed
the
refresh
branch
4 times, most recently
from
b20119e to
81a3acc
Compare
basil
commented
Oct 30, 2024
| @@ -43,16 +46,22 @@ public class FailureCauseProjectActionHudsonTest extends HudsonTestCase { | |||
| */ | |||
| @Test | |||
| public void testShowLastFailureOnProjectPage() throws Exception { | |||
| assumeFalse(Functions.isWindows()); | |||
There was a problem hiding this comment.
Now that we are running the test suite on Windows, fix this test so that it works on either Windows or Linux.
|
@TWestling This cleanup should complete the migration started in #182. There is no rush for it to be merged and released, but doing so while it is fresh in my mind would reduce risk in the (unlikely) case that there are any problems with the second half of the cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the migration started in #182.
Testing done
mvn clean verify