ASA 8392 #215
Merged
ASA 8392 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripajoym
reviewed
Jun 4, 2024
| @@ -22,8 +22,7 @@ error.threshold.invalid=Invalid entry. Enter an integer value. | |||
| error.malformed.url=Malformed URL {0}. | |||
| error.server.unavailable=AppScan plugin encountered an unexpected error while connecting to AppScan on Cloud. | |||
| error.mobile.analyzer=Incorrect user input. The legacy Mobile Analyzer technology is no longer supported, we recommend using our Static Analyzer scanning for Mobile Applications. | |||
| error.dynamic.AppScan360= Dynamic Analysis is available for AppScan on Cloud only. | |||
| error.dynamic.analyzer.AppScan360= HCL AppScan task failed: Dynamic analysis (DAST) is available in AppScan on Cloud only. | |||
| error.presence.AppScan360= Presence is available for AppScan on Cloud only. | |||
There was a problem hiding this comment.
It should be "in".
kripajoym
reviewed
Jun 4, 2024
| public boolean isAppScan360(){ | ||
| String url = m_credentials.getUrl(); | ||
| return url != null && !url.isEmpty() && !url.contains("appscan.com"); | ||
| @Override |
There was a problem hiding this comment.
Is this required to be override ? Can we add this is only in Jenkins Auth.
There was a problem hiding this comment.
As we are now using the isAppScan360() method in the appscan-plugin instead of the SDK. I will not go with overriding this method.
kripajoym
reviewed
Jun 4, 2024
| @@ -9,6 +9,7 @@ | |||
| import java.io.File; | |||
| import java.io.IOException; | |||
| import java.io.Serializable; | |||
| import java.net.Proxy; | |||
There was a problem hiding this comment.
why is this import required? there is no changes related to Proxy
There was a problem hiding this comment.
Removed this import.
kripajoym
reviewed
Jun 4, 2024
| @@ -325,17 +326,22 @@ public FormValidation doCheckScanFile(@QueryParameter String scanFile) { | |||
| return FormValidation.ok(); | |||
| } | |||
|
|
|||
| public FormValidation doCheckTarget(@QueryParameter String target,@RelativePath("..") @QueryParameter String credentials, @AncestorInPath ItemGroup<?> context, @QueryParameter String presenceId) { | |||
| public FormValidation doCheckTarget(@QueryParameter String target,@RelativePath("..") @QueryParameter String credentials, @AncestorInPath ItemGroup<?> context, @QueryParameter String presenceId) throws IOException { | |||
There was a problem hiding this comment.
None of the Formvalidations are throwing IO Exception why is it required ?
There was a problem hiding this comment.
Removed the IO exception.
vishalhcl-5960
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira02.hclpnp.com/browse/ASA-8392 - As a DevOps Engineer, I want to automate DAST Scan execution in AppScan 360 via HCL AppScan Jenkins Plugin.