Removed the scanType parameter #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripajoym
approved these changes
Apr 25, 2024
|
If the user pipeline includes the scanType, should we add a warning to inform the customer that the scan type has been removed from the DAST parameter? |
As per the internal discussion, We will show this change in change-log file instead of showing a warning in the console output. |
vishalhcl-5960
added a commit
that referenced
this pull request
May 21, 2024
* ScanType Parameter removal
vishalhcl-5960
added a commit
that referenced
this pull request
May 22, 2024
* Removed the scanType parameter (#210) * ScanType Parameter removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the scanType parameter.
From the backend perspective, only stopping the addition of scanType parameter in the properties map. If we removed the scanType parameter from the DynamicAnalyzer constructor too then it will show a warning message(WARNING: Unknown parameter(s) found for class type 'com.hcl.appscan.jenkins.plugin.scanners.DynamicAnalyzer': scanType) for the older pipelines which is not a expected behavior at all.