Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA-6905 & ASA-4814 #177

Merged
merged 4 commits into from
Oct 30, 2023
Merged

ASA-6905 & ASA-4814 #177

merged 4 commits into from
Oct 30, 2023

Conversation

vishalhcl-5960
Copy link
Collaborator

No description provided.

Includes cosmetic changes also
Copy link
Collaborator

@kripajoym kripajoym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a discussion about whether to retain the heading 'Additional Options.' The reason for this discussion is that if the 'Additional Options' field remains unchecked, it implies that the options selected within it are not applicable.

@vishalhcl-5960
Copy link
Collaborator Author

We can have a discussion about whether to retain the heading 'Additional Options.' The reason for this discussion is that if the 'Additional Options' field remains unchecked, it implies that the options selected within it are not applicable.

Yeah, we are retaining it, which means the script should show "false" of the Additional Options for the "upload Files and Folders" scan method.

@vishalhcl-5960 vishalhcl-5960 merged commit 9ad2a32 into jenkinsci:ASA-6905-&-ASA-4814 Oct 30, 2023
1 check failed
vishalhcl-5960 added a commit that referenced this pull request Nov 7, 2023
@vishalhcl-5960 vishalhcl-5960 deleted the ASA-6905 branch November 21, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants