Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe for index.jelly and to replace a test constructor on outdated plugin #571

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Add recipe for index.jelly and to replace a test constructor on outdated plugin #571

merged 1 commit into from
Jan 4, 2025

Conversation

jonesbusy
Copy link
Collaborator

Add recipe for index.jelly and to replace a test constructor on outdated plugin

A also ensure scm connect are transformed

Testing done

Automated tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

I will plan a release after merging this

@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jan 4, 2025
@jonesbusy jonesbusy marked this pull request as ready for review January 4, 2025 12:27
@jonesbusy jonesbusy merged commit 9716249 into jenkins-infra:main Jan 4, 2025
16 checks passed
@jonesbusy jonesbusy deleted the feature/ssh branch January 4, 2025 12:28
mawinter69
mawinter69 reviewed Jan 5, 2025
View reviewed changes
...izer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/recipes/EnsureIndexJelly.java
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does that differentiate from https://github.com/openrewrite/rewrite-jenkins/blob/main/src/main/java/org/openrewrite/jenkins/CreateIndexJelly.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mawinter69 mawinter69 mawinter69 left review comments

Assignees
No one assigned
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonesbusy @mawinter69