Break hardlinks to jenkins.io #6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
blogpost
documentation
NotMyFault
added
chore
and removed
gsoc
blogpost
documentation
probot-autolabeler
bot
added
blogpost
documentation
NotMyFault
removed
gsoc
blogpost
documentation
krisstern
approved these changes
Feb 26, 2023
|
Shouldn't https://github.com/jenkins-infra/jenkins.io/blob/master/scripts/check-hard-coded-URL-references have identified these, and if it didn't, does it need to be fixed? |
See #6081 (comment) |
|
@daniel-beck the check fails to run recursively, #6082 should fix that |
|
Thanks @zbynek @NotMyFault , looks like I had the same problem as Mark and expected the Ant semantics of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up my comment on #6079 (comment), to break hardlinks to jenkins.io.
This ensures redirections lead to the domain URL, and not jenkins.io. A typical use-case of this scenario is browsing pages locally or on netlify, without redirects to jenkins.io.