Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MDX 3 issues in markdown content #748

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix MDX 3 issues in markdown content #748

merged 1 commit into from
Nov 27, 2023

Conversation

nielsvanvelzen
Copy link
Member

Docusaurus 3 also updates the used MDX version. Our files contained some issues that this PR fixes:

  1. Links should never use <url> because this is also JSX. MDX 3 will now error on these usages. Updated to use [url](url) syntax
  2. FAQ page used {X} which needed escaping

Changes are also compatible with MDX 2 so these changes are safe to merge.

@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review November 27, 2023 15:40
@Shadowghost Shadowghost merged commit e36b446 into master Nov 27, 2023
7 checks passed
@Shadowghost Shadowghost deleted the nvv-mdx-3 branch November 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants