Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document fonts #690

Merged
merged 2 commits into from
Oct 9, 2023
Merged

document fonts #690

merged 2 commits into from
Oct 9, 2023

Conversation

felix920506
Copy link
Member

This PR aims to document where fonts are used in JF as suggested by Niels in jellyfin-web/#4848 (Comment)

The required changes will be PRed on web once this PR is merged.

Shadowghost
Shadowghost approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine. Maybe add a section on how to prevent the boxes in auto generated library images

@felix920506
Copy link
Member Author

I think they use system fonts but I'm not exactly sure. I will have to test.

@felix920506
Copy link
Member Author

Hi, I have done the testing and added it to the PR.

@Shadowghost Shadowghost merged commit fafa8ad into jellyfin:master Oct 9, 2023
7 checks passed
@felix920506 felix920506 deleted the fallback-fonts branch October 10, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix920506 @Shadowghost