1.0.2 fix memory leak

jeffreyliu8 · Jun 5, 2021 · 86460a7 · 86460a7
1 parent ca96e4c
commit 86460a7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,7 @@ Using FSD
 ##### Dependencies
 ```groovy
 	dependencies {
-	        compile 'com.github.jeffreyliu8:Native-Floyd-Steinberg-Dithering:1.0.1'
+	        compile 'com.github.jeffreyliu8:Native-Floyd-Steinberg-Dithering:1.0.2'
 	}
 ```
 

diff --git a/app/build.gradle b/app/build.gradle
@@ -39,5 +39,5 @@ dependencies {
     androidTestImplementation 'androidx.test.espresso:espresso-contrib:3.3.0'
 
 //    implementation project(":floydsteinbergdithering")
-    implementation 'com.github.jeffreyliu8:Native-Floyd-Steinberg-Dithering:1.0.1'
+    implementation 'com.github.jeffreyliu8:Native-Floyd-Steinberg-Dithering:1.0.2'
 }
diff --git a/floydsteinbergdithering/src/main/cpp/fsdither.cpp b/floydsteinbergdithering/src/main/cpp/fsdither.cpp
@@ -63,7 +63,7 @@ static void floydSteinberg(AndroidBitmapInfo *info, void *pixels) {
             // set the new pixel back in
             line[x] = newpixel;
 
-            int err = oldpixel - newpixel;
+            int err = (int)(oldpixel - newpixel);
 
             if (x + 1 < w)
                 d[y][x + 1] = d[y][x + 1] + (int) (err * (7. / 16));
@@ -77,6 +77,13 @@ static void floydSteinberg(AndroidBitmapInfo *info, void *pixels) {
 
         pixels = (char *) pixels + info->stride;
     }
+
+    //Free each sub-array
+    for (int i = 0; i < info->height; ++i) {
+        delete[] d[i];
+    }
+    //Free the array of pointers
+    delete[] d;
 }
 
 static void global_mono(AndroidBitmapInfo *info, void *pixels) {