fix systemd unit file hardcoded stats.js and config paths #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericy-jana I just submitted #53 because I have similar needs, but with RHEL. My changes include what you have proposed here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are parameterized for the init provider but hardcoded for systemd. This broke on our Debian 8 hosts which use
/usr/lib/node_modulesrather than/usr/local/lib/node_modules.The paths were already correct in
/etc/default/statsdwhich the module generates fromstatsd-defaults.erbso I just used it as a Systemd Environmentfile. This is probably not the most portable fix (e.g. I don't think it will work for RHEL-, but these are currently not using systemd anyway) but it seems better than hardcoding?