Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify ts #2781

Merged
merged 14 commits into from
Nov 21, 2024
Merged

fix: modify ts #2781

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fcd301a
fix: 适配harmony
irisSong Nov 4, 2024
0bf3823
fix: 适配样式
irisSong Nov 5, 2024
9e33d58
fix: 解决harmony下首次滚动动画不执行问题
irisSong Nov 5, 2024
844a60d
fix: update test
irisSong Nov 5, 2024
df4f024
fix: word spelling
irisSong Nov 5, 2024
ea6aa32
fix: cr 修改
irisSong Nov 6, 2024
d4adac8
fix: update icons-react-taro version
irisSong Nov 7, 2024
847c2ed
chore: update pnpm-lock.yaml
irisSong Nov 7, 2024
a4f2168
fix: 合并v3.0
irisSong Nov 8, 2024
b127792
Merge branch '3.0' into 3.0-countup
irisSong Nov 8, 2024
ddc9568
Merge remote-tracking branch 'upstream/V3.0' into 3.0-countup
irisSong Nov 10, 2024
f3ddd5b
fix: 合并3.0
irisSong Nov 10, 2024
0d3682d
fix: modify ts
irisSong Nov 21, 2024
38a2bc6
chore: merge 3.0
irisSong Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/packages/animatingnumbers/countup.taro.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,13 @@
})
.exec()
}
}, [numberArr])

Check warning on line 88 in src/packages/animatingnumbers/countup.taro.tsx

View workflow job for this annotation

GitHub Actions / lint 

React Hook useCallback has a missing dependency: 'duration'. Either include it or remove the dependency array

useEffect(() => {
if (numberArr.length) {
if (!isLoaded.current) {
isLoaded.current = true
// @ts-ignore
timerRef.current = setTimeout(() => {
setNumberTransform()
}, delay)
Comment on lines +94 to 97
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

建议避免使用 @ts-ignore 并添加正确的类型定义

使用 @ts-ignore 注释来抑制类型检查可能会掩盖潜在的问题。建议通过以下方式解决：

  1. 为 timerRef 添加正确的类型定义
  2. 根据运行环境（Taro）正确处理 setTimeout 的返回类型

建议应用以下修改：

- const timerRef = useRef()
+ const timerRef = useRef<ReturnType<typeof setTimeout>>()

- // @ts-ignore
  timerRef.current = setTimeout(() => {
    setNumberTransform()
  }, delay)

Committable suggestion skipped: line range outside the PR's diff.

Expand Down
Loading