Add givens2 gate #253
Merged
Add givens2 gate #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsung
commented
Aug 18, 2024
| @@ -269,7 +269,8 @@ def test_all_gate_methods(self, Circ): | |||
| ("cu1", 2, 1), | |||
| ("fsim", 2, 2), | |||
| ("fsimg", 2, 5), | |||
| ("rzz", 2, 1), | |||
There was a problem hiding this comment.
rzz is already tested above
kevinsung
force-pushed
the
givens2
branch
2 times, most recently
from
e3f5b7d
to
af1073a
Compare
|
Rerunning the notebook that lists gates produced a huge diff. Is there a recommended way to keep the diff small? FYI there is a tool squeaky, that helps format Jupyter notebooks to keep the diffs small in situations like these. |
|
All looks good to me! Thanks very much.
Thanks for pointing out squeaky, I will check it out for future use. Currently yes I tend to just view the diffs with vscode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245