Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty lines in dimacs #215

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Fix empty lines in dimacs #215

merged 1 commit into from
Dec 24, 2023

Conversation

jjcmoon
Copy link
Contributor

@jjcmoon jjcmoon commented Dec 23, 2023

Encountered a bug where .cnf files couldn't be loaded if they contain empty lines (see below).
Fixed by moving the empty line check up.

  File ".../quimb/tensor/tensor_builder.py", line 2607, in cnf_file_parse
    if args[0] == "p":
IndexError: list index out of range

@pep8speaks
Copy link

Hello @jjcmoon! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2761:1: W293 blank line contains whitespace

@jcmgray
Copy link
Owner

jcmgray commented Dec 24, 2023

LGTM, thanks!

@jcmgray jcmgray merged commit 9f7c300 into jcmgray:main Dec 24, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants