Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch UnicodeDecodeError in is_already_migrated #597

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Mogost
Copy link
Member

@Mogost Mogost commented Nov 4, 2024

Fix #593

@Mogost Mogost self-assigned this Nov 4, 2024
@Mogost Mogost requested a review from camilonova November 4, 2024 13:03
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (ef24fcb) to head (52de15c).
Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
constance/migrations/0003_drop_pickle.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   89.92%   84.23%   -5.69%     
==========================================
  Files          31       21      -10     
  Lines        1032      736     -296     
  Branches      104      117      +13     
==========================================
- Hits          928      620     -308     
- Misses         69       83      +14     
+ Partials       35       33       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camilonova camilonova merged commit a604a5e into jazzband:master Nov 4, 2024
9 of 11 checks passed
@Mogost Mogost deleted the fix-593 branch November 4, 2024 16:14
@Mogost
Copy link
Member Author

Mogost commented Nov 4, 2024

@camilonova I have tagged a new version with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When migrating migration 0003 I get a UnicodeDecodeError error...
2 participants