-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce local My Favourites for SoundCloud #51
base: master
Are you sure you want to change the base?
Conversation
call the current tracks of stored user
SoundCloud favourites
fix fav json when it's empty
first use of feature
I think we can just use the client ID from the SoundCloud Android app for this. I'll test it this month. If it doesn't work, I'll merge your PR. |
Cool, let me know how it goes, or if I can help you with that. |
@mr-pineapple-nz Short status update: I'm currently busy implementing some stuff in the Vimeo add-on. I did not forget about your PR. I'll try to find some time next week. |
OK. I tried your idea regarding the client id, not much success :( |
@mr-pineapple-nz I'm done with the Vimeo add-on and will take a look this week. Would it be ok for you if this feature was only implemented for Kodi 19 (Matrix)? Or are you still using Kodi 18? |
@jaylinski Can be merged to v19 of course. I haven't upgraded yet but will do soon. |
@jaylinski is there any update on this? Do you need anything else from me? |
@mr-pineapple-nz Sorry for not responding for so long. Good news: I finally found some motivation to dig into this issue again and started to reverse the mobile-app API in order to implement a login: https://github.com/jaylinski/kodi-addon-soundcloud/pull/53/files I'm pretty confident that I can get the login to work and lined out my plans for it here: #40 I'll keep this PR open for now. |
cool @jaylinski . Let me know if I can help, I'm happy to do so :) |
As it's not likely that SoundCloud will release new application client ids to access it's
APIs, (especially authentication) this change allows the user to store users and tracks
under a special favorite menu.
Happy to discuss further changes/improvements