Support for macOS #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a reset() to LyricsViewTimer so that a LyricsView can display lyrics from different song without the needs of re-initialization
I've seen crash that these index out of bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added subspec for iOS and macOS
Made a AppKit(macOS) compatible LyricsView
Added example app for iOS and macOS, so people can test/develop using the example app
Deleted the Xcode project on root directory
Some edit to README to reflect the change
Added reset() to the LyricsViewTimer, so you can reset the LyricsView and give it a new lyrics to play. You have to re-initialize a new view in current version.