feat: add ignore_methods to ignore setup of null-ls source method types
#93
Conversation
mehalter
changed the title
ignore_types to ignore setup of null-ls source typesignore_methods to ignore setup of null-ls source method types
| local types = _.filter_map(function(method) | ||
| if vim.tbl_contains(ignored_methods, method) then |
There was a problem hiding this comment.
I was thinking why not just allow line 54 to be overridden with allowed_methods. Also that's interesting, people can't just replace null-ls completely. You need it somewhat still
There was a problem hiding this comment.
Yeah, I think it just becomes more verbose to list off allowed methods. It's more typical you just want to ignore them. I'm good either way !
Definitely when building extra lazy specs such as in LazyVim extras and AstroCommunity it makes it easier to be additive when it's ignore because you can add those in rather than hope that the opts currently have the full allowed_methods populated and then to remove a method. If that makes sense.
There was a problem hiding this comment.
Here is an example of it making sense for it to be ignore_methods if you are interested: https://github.com/AstroNvim/astrocommunity/pull/756/files
There was a problem hiding this comment.
I opened another PR as a different approach/option for tackling this type of thing. Let me know what you think!
|
It sounds like the other PR is more in the right direction we want to move, so I'll go ahead and close this for now |
A lot more people nowadays are starting to use more tools like
conformornvim-lintand things which replace certain functionality in null-ls but not all of it. It might be a good idea to add the ability to ignore types by default. Like if I'm usingconformand still want to rely onmason-null-lsfor diagnostics and code actions, I could add to the setup likeignore_methods = { "formatting" }since that's handled byconform. Or if I use bothconformandnvim-lintbut want to usenull-lsfor code actions, addingignore_methods = { "formatting", "diagnostics" }which won't add those types to the handlers when they are called.Update: originally called
ignore_types,ignore_methodsaligns better with the terminology used here and innull-ls/none-ls.