This repository has been archived by the owner on May 28, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Grammar and spelling in getting-started and user-guide xml files. #3653
Open
jcalcote
wants to merge
1
commit into
javaee:master
Choose a base branch
from
jcalcote:grammer/update-getting-started-user-guide
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Grammar and spelling in getting-started and user-guide xml files. #3653
jcalcote
wants to merge
1
commit into
javaee:master
from
jcalcote:grammer/update-getting-started-user-guide
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great, thanks. We need to wait till OCA is processed. |
@jcalcote Did you send your OCA to oracle-ca_us(at)oracle(dot)com ? If so when? I can't find it?! |
Hi Pavel and David,
Here's the email I sent to [email protected] on August 31, 2017:
Gmail - OCA document for John Calcote to work o...
<https://drive.google.com/file/d/17HK9U2o-9jDd8KImJo5e5TOIwakVjUDc9lu5LeGClSx_uPaQxSsYNE67h0O7EwBsgPSAVaUrB6DxSF6_/view?usp=drive_web>
Regards,
John
…On Mon, Sep 4, 2017 at 10:31 PM, David Delabassee ***@***.***> wrote:
@jcalcote <https://github.com/jcalcote> Did you send your OCA to
oracle-ca_us(at)oracle(dot)com ? If so when? I can't find it?!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/jersey/jersey/pull/3653#issuecomment-327068542>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADA8teB5JERtvnS_3BrremExxRx2BFXks5sfM6dgaJpZM4PJjPt>
.
|
@jcalcote I can't access the attached OCA. Can you send it directly to david.delabassee@orac.... ? |
Sent (on another thread - directly to you).
…On Mon, Sep 4, 2017 at 11:27 PM, David Delabassee ***@***.***> wrote:
@jcalcote <https://github.com/jcalcote> I can't access the attached OCA.
Can you send it directly to ***@***.*** ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/jersey/jersey/pull/3653#issuecomment-327074776>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADA8q_Q_q0KEJcYws1-6IsPQ_bbtTkgks5sfNvbgaJpZM4PJjPt>
.
|
@jcalcote Still nothing! I guess it must be considered as spam?! 😔 Can you send it to david.delabassee@gmail... instead? |
Forwarded to your gmail account...
…On Sep 5, 2017 1:17 AM, "David Delabassee" ***@***.***> wrote:
@jcalcote <https://github.com/jcalcote> Still nothing! I guess it must be
considered as spam?! 😔 Can you send it to ***@***.***
instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/jersey/jersey/pull/3653#issuecomment-327092045>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADA8kavMGDmaIfNuENH3_mLZTAf0ioHks5sfPWUgaJpZM4PJjPt>
.
|
@pavelbucek @jcalcote 's OCA has been reviewed and approved! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jersey Maintainers (moved this PR to a branch so I could work on other things at the same time). I noticed while reading the Jersey User Guide that it could use a little grammar help. To this end, I've started by correcting the getting-started and user-guide xml files. If you like and accept these changes, I'll continue with this project as time allows. I've emailed a signed copy of the OCA to Oracle - hopefully it won't take them long to incorporate into the OCA list. Thanks for a great project!