Skip to content
This repository has been archived by the owner on May 28, 2018. It is now read-only.

Fix "ReferenceError: event is not defined" on Firefox #213

Closed
wants to merge 1 commit into from

Conversation

fabriziocucci
Copy link
Contributor

While on Chrome the problem is not visible, on Firefox the "New items size: ..." message is not shown due to the ReferenceError.

While on Chrome the problem is not visible, on Firefox the "New items size: ..." message is not shown due to the ReferenceError.
@jerseyrobot
Copy link
Contributor

Can one of the admins verify this patch?

@AdamLindenthal
Copy link
Member

Hi Fabrizio,

nice catch, thanks. Unfortunately, in order to merge the pull request, you would have to sign Oracle Contributor Agreement. It usually takes some time (multiple weeks) to be processed.
If you plan to submit more patches in the future, it makes perfect sense to do it (it only needs to be done with the first pull request).
If not, it's up to you - you are welcome to do so, but I understand that going through that process because of such a minor change might not be worth it for you.

Please, let me know, if you are willing to do it or if we should fix this via internal commit.

Thanks,
Have a nice day.

Adam

@fabriziocucci
Copy link
Contributor Author

Hi Adam,

thanks for your answer.

I was under the impression that I did already signed the OCA but I can't find myself in the list so probably I was wrong. I would be more than happy to go through the process since I'm planning to contribute.

I'll try to sign it today but I'll give you confirmation as soon as possible.

Thanks,
Fabrizio

@AdamLindenthal
Copy link
Member

Hi Fabrizio, glad to hear that.

If you have the impression, that you already sent the OCA, please check your inbox first, maybe you really did and the problem is on our side. If so, please let me know and I would try to ping our colleague, that takes care of that.

Thanks,
Adam

@fabriziocucci
Copy link
Contributor Author

Hi Adam,

I just double checked: I did sign a contribution agreement recently but it was for another project! :)

So, tomorrow I will print the OCA, sign it, scan it and send it to oracle-ca_us [at] oracle [dot] com.

Thanks,
Fabrizio

@fabriziocucci
Copy link
Contributor Author

Mission accomplished! 😎

I will let you know as soon as I get back the confirmation.

Thanks,
Fabrizio

@delabassee
Copy link
Member

Fabrizio, your OCA is now approved.

Thanks,

@fabriziocucci
Copy link
Contributor Author

Apparently, this sample has been split in two:

  • sse-item-store-jaxrs-webapp
  • sse-item-store-jersey-webapp

Re-proposing fix for both samples here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants