Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full support for accessibility (A11y) according to WCAG 2.1 & W3C AA #152

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jmalarcon
Copy link

It includes PR #151, needed to be able to develop notie without problems.

This PR adds full support for accessibility according to WCAG 21 and W3C AA.

This is a must have nowadays and will enhance the library a lot if you accept the Pull Request.

HTH.

@luizkowalski
Copy link

at this point, I think you should fork the project, @jmalarcon. the author hasn't replied to other PRs in like 4 years

@jmalarcon
Copy link
Author

Yeah, I know. It's a pity.

I made this PR through our fork here: https://github.com/Krasis/notie because we use this library in our product and wanted to contribute.

I'll try to reach him outside GitHub and let's see if he agrees to let me take over the main repo. I'd prefer to use the main one instead of ours, and there are some interesting PRs in it already.

@luizkowalski
Copy link

hey @jmalarcon, did you manage to contact him outside GitHub? any news from his side?

@jmalarcon
Copy link
Author

Yes, I contacted him through LinkedIn to no avail. I never got a response. The guy is still alive, since it makes some pushes to the repo he keeps for his personal site, but I guess he's not interested in this project anymore. I offered myself to take over the project if he wanted. However, it would have been nice if he simply said that as an answer 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants