Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GitHub Action templates' cache key by removing glob #800

Closed
wants to merge 1 commit into from
Closed

fix GitHub Action templates' cache key by removing glob #800

wants to merge 1 commit into from

Conversation

felixmosh
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 15, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/3vx1xhwpx
✅ Preview: https://tsdx-git-fork-felixmosh-fix-799.formium.vercel.app

@agilgur5 agilgur5 linked an issue Aug 15, 2020 that may be closed by this pull request
Github Actions templates cache doesn't hit due to hashing bug #799
Closed
@agilgur5 agilgur5 changed the title Fix the cache key, closes #799 fix GitHub Action templates' cache key Aug 15, 2020
@agilgur5 agilgur5 changed the title fix GitHub Action templates' cache key fix GitHub Action templates' cache key by hashing single yarn.lock Aug 15, 2020
@agilgur5 agilgur5 changed the title fix GitHub Action templates' cache key by hashing single yarn.lock fix GitHub Action templates' cache key by removing glob Aug 15, 2020
@agilgur5 agilgur5 added the scope: templates Related to an init template, not necessarily to core (but could influence core) label Aug 19, 2020
@agilgur5 agilgur5 mentioned this pull request Sep 21, 2020
Merged
@agilgur5
Copy link
Collaborator

per #799 (comment), this has been superseded by #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
progress: blocked scope: templates Related to an init template, not necessarily to core (but could influence core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Actions templates cache doesn't hit due to hashing bug
2 participants
@felixmosh @agilgur5