upgrade to parcel-bundler^1.12.5 from parcel^1.12.3 in templates #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le dirs This will fix 'Invalid Version: undefined' error due to parcel v1
This comment was marked as spam.
This comment was marked as spam.
carlostorreswav
approved these changes
Jun 13, 2021
thebiltheory
approved these changes
Aug 5, 2021
|
@Catminusminus something seems to be wrong with the checks. |
binvb
approved these changes
Aug 24, 2021
|
I got the three approvements, so I will explain this situation. Let me get straight to the point, this project seems to be "dead". To unlock CI for this PR, an approvement by a reviewer with write access permission is required. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Just tried adding parcel bundler with the given version @Catminusminus Although I can now see this console error, Any ideas what this could be? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #980.
Currently, in the two template projects (react and react-with-storybook), you will encounter "Invalid Version: undefined" errors when you type
yarn startin the example directories.This is due to specifying "parcel": "^1.12.3" in package.json and upgrading to 1.12.5 will fix the problem.
However, v1.12.5 exists only in parcel-bundler package, so I change "parcel": "^1.12.3" to "parcel-bundler": "^1.12.5".
In addition, upgrading to parcel v2 beta will break hot module reloading (#980 (comment)), so I decided to use not parcel v2 but parcel-bundler.