-
Notifications
You must be signed in to change notification settings - Fork 508
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(fix): remove faulty tsconfig.json include of test dir
- `include` means all files that should be compiled, and the test dir should definitely not be compiled - this was causing issues where declarations were being output into dist/ for all files in test/ - that shouldn't happen and it means `build` was unnecessarily slowed down in order to process test/ files - default `exclude` that was added of *.spec/*.test files, originally for co-located tests, ended up making most test/ dir files excluded too, but not, say, test utils that don't have a .spec or .test suffix - this was also causing errors with the `rootDir: './src'` change as the test/ dir is outside of the rootDir - problem wasn't the rootDir, but that the test/ dir shouldn't be compiled or processed in any way (test): ensure test/*.test.ts and test/*.ts files are correctly excluded and don't have declarations generated - and that they don't error with rootDir: './src' (test): ensure types/*.d.ts don't error with rootDir and don't have declarations re-generated either - n.b. tsc won't re-generate them either, they don't get copied to outDir, this isn't new or different behavior (env/test): Jest shouldn't run / should ignore tests inside of fixtures
- Loading branch information
Showing
8 changed files
with
24 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// this is to test .test/.spec files in the test/ dir are excluded | ||
|
||
// and that rootDir: './src' doesn't error with test/ files |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
// this is to test that test helper files in the test/ dir are excluded | ||
// i.e. files in test/ that don't have a .spec/.test suffix | ||
|
||
// and that rootDir: './src' doesn't error with test/ files |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// this is to test that rootDir: './src' doesn't error with types/ files | ||
|
||
// and that declaration files aren't re-output in dist/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters