Skip to content

Commit

Permalink
ci: make internal job names more consistent w/ templates'
Browse files Browse the repository at this point in the history
- Adding a matrix and `bahmutov/npm-install` brought the templates
  closer to internal, now do the inverse

- Add "Checkout repo" name for checkout Action
  - previously had no name internally
- Reorder config options for matrix to match templates
- Use "Node" consistently, not "node" or "Node.js"

- Also upgrade to actions/checkout@v2 since the templates have had that
  since their inception
  • Loading branch information
agilgur5 committed Sep 21, 2020
1 parent 8449699 commit 49a3521
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ jobs:
name: Lint & Deduplicate deps on node 10.x and ubuntu-latest

steps:
- uses: actions/checkout@v1
- name: Use Node.js 10.x
- name: Checkout repo
uses: actions/checkout@v2
- name: Use Node 10.x
uses: actions/setup-node@v1
with:
node-version: 10.x
Expand All @@ -27,18 +28,18 @@ jobs:
run: yarn deduplicate:check

test:
runs-on: ${{ matrix.os }}
name: Test on Node ${{ matrix.node }} and ${{ matrix.os }}

runs-on: ${{ matrix.os }}
strategy:
matrix:
node: ['10.x', '12.x', '14.x']
os: [ubuntu-latest, windows-latest, macOS-latest]

name: Test on node ${{ matrix.node }} and ${{ matrix.os }}

steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node }}
- name: Checkout repo
uses: actions/checkout@v2
- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
Expand Down

1 comment on commit 49a3521

@vercel
Copy link

@vercel vercel bot commented on 49a3521 Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.