Percent encode paths #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary intention is to fix the case where filenames have spaces in them and this plugin doesn't encode the URL properly so it appears as if vivify can't refresh We do this whether (n)vim has python3 support or not, but with python3 support do a proper encoding with a library to handle more esoteric cases, for example curly brackets in filenames. We found that even without the library, characters such as ä, á, ñ, € already work, so it's probably a very rare case where you need any more meticulous encoding for filenames. And then even if that occurs, enabling python3 support will solve it :)
Closed
jannis-baum
reviewed
Sep 16, 2024
Co-authored-by: Jannis Baum <[email protected]>
jannis-baum
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #20
The primary intention is to fix the case where filenames have spaces in
them and this plugin doesn't encode the URL properly so it appears as if
vivify can't refresh
We do this whether (n)vim has python3 support or not, but with python3
support do a proper encoding with a library to handle more esoteric
cases, for example curly brackets in filenames.
We found that even without the library, characters such as ä, á, ñ, €
already work, so it's probably a very rare case where you need any more
meticulous encoding for filenames. And then even if that occurs,
enabling python3 support will solve it :)