Fix race between close() and get() in StoreDirect #969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race, when Store is closed, but there are still iterators somewhere, which may use it.
In the concurrent environment,
get()
call can passassertNotClosed
assertion, but acquire the lock afterStore::close
completed.Probably linked to #892 as well, if there is a scenario with concurrent
close
andget
.Note: this will still lead to exception, however it will be an
IllegalAccessError
, rather thenNullPointerException