Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race between close() and get() in StoreDirect #969

Open
wants to merge 1 commit into
base: release-3.0
Choose a base branch
from

Conversation

aleksandrserbin
Copy link

There is a race, when Store is closed, but there are still iterators somewhere, which may use it.
In the concurrent environment, get() call can pass assertNotClosed assertion, but acquire the lock after Store::close completed.

Probably linked to #892 as well, if there is a scenario with concurrent close and get.

Note: this will still lead to exception, however it will be an IllegalAccessError, rather then NullPointerException

@aleksandrserbin aleksandrserbin changed the title Update StoreDirect.kt Fix race between close() and get() in StoreDirect Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant