Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Vscode injection #27

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

haz
Copy link

@haz haz commented Jul 8, 2019

Not yet ready to merge.

  • This is the session id to load for testing things: ZwmKioETsTG4OvZ
  • This is the new plugin implementation that implements the injection (search for vscode): http://www.haz.ca/newsolver.js
  • General strategy is that a vscode-specific function is encoded as part of the settings; if it exists, then the vscode user is prompted to run it.
  • Parameters for the function are set in stone: the settings for the plugin (which may contain specific configuration information for that plugin), as well as vscode custom API (to be decided on).
  • Current hangup: how to get access to the right URI for changing settings, and deciding on what exactly should be included in the vscode API for the plugin to use.

The URI access that I'm using is a bit too hacky -- it's the only place in the vscode datastructure that I was able to find the right URI. Here's the full function that's being injected (note that this needs to be post-TS->JS compilation):

vscode_api.vscode.workspace.getConfiguration("pddlPlanner", vscode_api.vscode.workspace.workspaceFolders[0].uri)
                                    .update("executableOrService",
                                            plugin_settings.url + "/solve",
                                            vscode_api.vscode.ConfigurationTarget.WorkspaceFolder);

@haz
Copy link
Author

haz commented Aug 3, 2019

So where should we take this PR from here? What things should be added / changed? CC @jan-dolejsi

@gifhuppp
Copy link

แล้วเราจะเอา PR ไปจากที่นี่ที่ไหน? ควรเพิ่ม/เปลี่ยนแปลงอะไรบ้าง? CC @jan-dolejsi

Copy link

@gifhuppp gifhuppp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client/src/session/SessionRepository.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants