Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to gh-pages diff #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stu0292
Copy link

@stu0292 stu0292 commented Dec 21, 2020

Hi James,

Really good PWA tutorial, I like the minimalist, no-dependencies approach!

Took me a while (and some hair-pulling) to notice that some changes are needed from the version in your medium post to deploy this on GitHub pages. I think pointing out those differences somewhere would help - I've just added a link to the README.

What do you think?

Cheers,

Stu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants