Fix inference of parameters from large based integer literals

jameshanlon · Sep 4, 2023 · a93aa7c · a93aa7c
1 parent 7486826
commit a93aa7c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/source/ast/Expression.cpp b/source/ast/Expression.cpp
@@ -388,7 +388,7 @@ std::tuple<const Expression*, const Type*> Expression::bindImplicitParam(
         if (lhsType->isIntegral()) {
             bitwidth_t bits = lhsType->getBitWidth();
             if (expr.isUnsizedInteger())
-                bits = 32;
+                bits = std::max(bits, 32u);
 
             // Keep the signed flag but force four state.
             auto flags = lhsType->getIntegralFlags();

diff --git a/tests/unittests/ast/ExpressionTests.cpp b/tests/unittests/ast/ExpressionTests.cpp
@@ -2956,3 +2956,18 @@ endclass
     compilation.addSyntaxTree(tree);
     NO_COMPILATION_ERRORS;
 }
+
+TEST_CASE("Type of unsized based literal") {
+    auto tree = SyntaxTree::fromText(R"(
+module m;
+    parameter p = 'd999999999999;
+endmodule
+)");
+
+    Compilation compilation;
+    compilation.addSyntaxTree(tree);
+    NO_COMPILATION_ERRORS;
+
+    auto& p = compilation.getRoot().lookupName<ParameterSymbol>("m.p");
+    CHECK(p.getType().toString() == "logic[39:0]");
+}