-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OTEL MeterProvider in Telemetery Settings #6144
base: main
Are you sure you want to change the base?
Added OTEL MeterProvider in Telemetery Settings #6144
Conversation
Signed-off-by: shinigami-777 <[email protected]>
@shinigami-777 The purpose of this ticket isn't necessarily to change how the settings are being initialized but rather to pass down the meter provider from OTEL. You can break down this task as follows:
|
Signed-off-by: shinigami-777 <[email protected]>
@mahadzaryab1 Thanks for the clarity. I have made the necessary changes. |
pkg/telemetery/settings.go
Outdated
Metrics metrics.Factory | ||
ReportStatus func(*componentstatus.Event) | ||
Host component.Host | ||
LeveledMeterProvider func(_ configtelemetry.Level) metric.MeterProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we've got this field available to us - we also want to be able to use it. For example, in the query server we currently hardcode the meter provider but now we can pass it from telset
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed it in the query server.
Signed-off-by: shinigami-777 <[email protected]>
Signed-off-by: shinigami-777 <[email protected]>
Signed-off-by: shinigami-777 <[email protected]>
@mahadzaryab1 I have propagated the setting everywhere in the codebase. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6144 +/- ##
==========================================
+ Coverage 96.47% 96.49% +0.01%
==========================================
Files 354 354
Lines 20126 20127 +1
==========================================
+ Hits 19417 19421 +4
+ Misses 524 522 -2
+ Partials 185 184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Which problem is this PR solving?
Description of the changes
LeveledMeterProvider
in the Telemetery Settings struct . This has been propagated to other parts in the codebase.How was this change tested?
make fmt
andmake lint test
for testing.Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test