Skip to content

Commit

Permalink
Update pkg/testutils/leakcheck.go
Browse files Browse the repository at this point in the history
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Manik Mehta <[email protected]>
  • Loading branch information
Manik2708 and yurishkuro authored Dec 10, 2024
1 parent 5806b49 commit 3a4faf5
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions pkg/testutils/leakcheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@ func IgnoreOpenCensusWorkerLeak() goleak.Option {
return goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start")
}

// IgnoreGoMetricsMeterLeak prevents the leak created by go-metrics which is being used by Sarama (Kafka Client) in Jaeger v1. This reason of this leak is
// IgnoreGoMetricsMeterLeak prevents the leak created by go-metrics which is
// used by Sarama (Kafka Client) in Jaeger v1. This reason of this leak is
// not Jaeger but the go-metrics used by Samara.
// See these issues for the context
// https://github.com/IBM/sarama/issues/1321,
// https://github.com/IBM/sarama/issues/1340, and
// https://github.com/IBM/sarama/issues/2832
// - https://github.com/IBM/sarama/issues/1321
// - https://github.com/IBM/sarama/issues/1340
// - https://github.com/IBM/sarama/issues/2832
func IgnoreGoMetricsMeterLeak() goleak.Option {
return goleak.IgnoreTopFunction("github.com/rcrowley/go-metrics.(*meterArbiter).tick")
}
Expand Down

0 comments on commit 3a4faf5

Please sign in to comment.