Updates for ansible-akamai #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update akamai.py with linting fixes, documentation and examples
swtch1
reviewed
Jan 26, 2023
swtch1
reviewed
Jan 26, 2023
swtch1
reviewed
Jan 26, 2023
| @@ -1,29 +1,130 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/python | |||
There was a problem hiding this comment.
I believe keeping /usr/bin/env python will perform correctly but has an added advantage in some environments.
https://www.baeldung.com/linux/bash-shebang-lines.
Is there a specific reason to change it?
There was a problem hiding this comment.
Not a major preference, just following the ansible guidelines.
There was a problem hiding this comment.
Oddly enough, the ansible-core native modules don't include shebang at all. Example
swtch1
reviewed
Jan 26, 2023
swtch1
reviewed
Jan 26, 2023
swtch1
approved these changes
Jan 26, 2023
Remove whitespace before curly brackets and lower case edgegrid-python
Remove comment
* Update method arg to include the choices GET, POST, PUT * Update body arg to be type json instead of type str
|
@jacob-hudson please let me know what you think and if you'd like to see any changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation, fix pylint and pycodestyle issues, remove python2 support, add python3 support