Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalizes fixes for #19 by dropping configurations and defaulting the keep-listening behavior #114

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mattsilber
Copy link
Collaborator

@mattsilber mattsilber commented May 24, 2024

These changes are all related to #19:

  • Drops configurations for setUsePreDrawOverGlobalLayoutEnabled. Using the OnPreDrawListener over the OnGlobalLayoutListener did not solve the underlying issue; it just delayed the start of the sizing process under normal cases.
  • Drops configurations for setAttemptLastDitchPostForLayoutResolutionFailure. The last-ditch post on receiving invalid sizes caused more harm than good.
  • Drops configurations for setKeepListeningForDrawUntilValidSizeDiscovered. The continued listening for a valid size was the ultimate fix and has become the default behavior moving forward.
  • Adds migration guide noting the signature changes for what will be version 4.0.0

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.63%. Comparing base (c918af5) to head (d687de6).

Files Patch % Lines
...jackpocket/scratchoff/ScratchableLayoutDrawer.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   83.76%   83.63%   -0.13%     
==========================================
  Files          10       10              
  Lines         659      611      -48     
  Branches       81       76       -5     
==========================================
- Hits          552      511      -41     
+ Misses         73       67       -6     
+ Partials       34       33       -1     
Flag Coverage Δ
unit 83.63% <80.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant