Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie support #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CJGlitter
Copy link

@CJGlitter CJGlitter commented Jul 3, 2024

Problem

Slack changed their auth method to require cookies, breaking the functionality of this project

Solution

Switch to Emojme v2.0.1 to enable cookie support, add handlers for cookie as an additional parameter

Future fixes

  • generate.sh: Add logic to support either option:
    • ./generate.sh "$NAME" "$SUBDOMAIN" "$TOKEN" "$COOKIE"
    • ./generate.sh "$NAME" "$AUTH_BLOB"
  • generate.js: I updated the generate.js file to handle parsing the JSON object and using the cookie, but I did not make it functional. I figure that will be a cleaner solution down the line so I wanted to build for the future.

Notes

I ran another generate for your emojis to grab your latest list in case you didn't grab it when you left BT. Included yours in the README and emoji/ directory.

@CJGlitter CJGlitter marked this pull request as ready for review July 3, 2024 19:10
@CJGlitter
Copy link
Author

@jackellenberger it won't let me request a reviewer on the side panel here, but it's ready to go!

@CJGlitter
Copy link
Author

CJGlitter commented Jul 3, 2024

Just realized I should probably add some logic to support just the auth-blob when using the sh file. I can add that as a future fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant