Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for php 8.1+ #375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for php 8.1+ #375

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e19ae83
fix deprecate parameter pass for PDO::quote php8.1
DarkVss Apr 3, 2023
2a85377
fix miss-naming
DarkVss Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion idiorm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,15 @@ protected static function _log_query($query, $parameters, $connection_name, $que
$bound_query = $query;
} else {
// Escape the parameters
$parameters = array_map(array(self::get_db($connection_name), 'quote'), $parameters);
foreach ($parameters as &$parameter) {
if (is_string($parameters) === true) {
$parameter = [self::get_db($connection_name), "quote"]($parameter);
Copy link

@devjet devjet Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it has to be:
if (is_string($parameter) === true) {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, u right but its still have no sense cz author dont care about project)) (in my separated version var has right typing)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devjet

could you say what error is it fixing? it is not clear

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devjet

could you say what error is it fixing? it is not clear

check original comment for PR ⬆️ or read this issue

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I see, it's a deprecated message only. Ok then it will be a problem on php 9 only, maybe you could inform it on your title, just to be clear it is fixing an deprecation message.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I see, it's a deprecated message only. Ok then it will be a problem on php 9 only, maybe you could inform it on your title, just to be clear it is fixing an deprecation message.

in full case it not only disabling deprecated message , this changes make more cleanest SQL code - null as NULL, boolean as BOOLEAN( e.g. TRUE or FALSE instead of '1' and '')

Copy link

@eerison eerison Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cz author dont care about project

Just to point out, that isn't true, he is replying when he is mentioned.

in full case it not only disabling deprecated message , this changes make more cleanest SQL code - null as NULL, boolean as BOOLEAN( e.g. TRUE or FALSE instead of '1' and '')

well if you want to "clean up" the code and introduce a different behaviour you definitely need to write test for it, and it would be nice if you could explain the benefits of this.

Output Deprecated: PDO::quote(): Passing null to parameter #1 ($string) of type string is deprecated in C:\VHOST\VHOST8\idiorm\vendor\j4mie\idiorm\idiorm.php on line 539

checking your message ... it is complain about null value for quote function ... in theory there are null values on $parameter, But the question is : should $parameter contain null values?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heaven sake...
at the first: isuue created >2 year, PR >1 y. yeah, author dont care about proj
second: code upgrd for disable message about deprecated passing (read original issue)
thrid: if u dont what this code do - read the code, no explanation for it

P.S.
if u wanna to some rhetoric - go to some chat. i just pushed updates for issue solution, no more. this repo look like abandoned, so this discussion have no sense

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this discussion have no sense

if you don't want move this forward, then it could be closed, couldn't it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eerison idiorm has a problem with inserting null values
this is problem because one have to edit something in vendors directory to fix it.

} else if (is_bool($parameter) === true) {
$parameter = $parameter === true ? 'TRUE' : 'FALSE';
} else if ($parameter === null) {
$parameter = 'NULL';
}
}

if (array_values($parameters) === $parameters) {
// ? placeholders
Expand Down