Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove native dialog #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NiklasMerz
Copy link
Collaborator

Request for comments: Remove social share dialog
I found a way to do that, but I think this sould be configurable.

@j3k0 What do you think about a mode for this plugin, which removes the native dialog.

@NiklasMerz NiklasMerz requested a review from j3k0 September 14, 2018 13:18
@j3k0
Copy link
Owner

j3k0 commented Sep 18, 2018

Sure, good idea. Sorry I've been very busy lately, I'll review the PRs.

@j3k0
Copy link
Owner

j3k0 commented Sep 18, 2018

If I understand correctly, this PR completely removes the native dialog.

I wonder about Apple's reaction to that. Well, the plugin already is borderline, but I remember having read that ShareExtension should do their job before switching to the app.

Anyway, I guess it should be an interesting option. Default true when the type identifier isn't public.image, false otherwise, probably.

@NiklasMerz
Copy link
Collaborator Author

@j3k0 Thanks for all reviews.

Good point. The final PR should at least have an option to enable the dialog if the developer wants to do that.

I will try to do that when I find time. For now this PR removes the dialog completely if anybody needs this.

@j3k0
Copy link
Owner

j3k0 commented Sep 18, 2018

@NiklasMerz Welcome. I published version 1.2.0 with the 3 PRs merged today. I didn't really test much, so I trust you guys that it's stable enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants