Merge pull request #107 from IsraelHikingMap/master

Fix #82 building in CI context
j3k0 · Aug 6, 2020 · d6a2bf2 · d6a2bf2
2 parents 557236d + bb167ed
commit d6a2bf2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/hooks/iosAddTarget.js b/hooks/iosAddTarget.js
@@ -124,6 +124,10 @@ function parsePbxProject(context, pbxProjectPath) {
 
 function forEachShareExtensionFile(context, callback) {
   var shareExtensionFolder = path.join(iosFolder(context), 'ShareExtension');
+  if (!fs.existsSync(shareExtensionFolder)) {
+    console.error('!!  Shared extension files have not been copied yet!!');
+    return;
+  }
   fs.readdirSync(shareExtensionFolder).forEach(function(name) {
     // Ignore junk files like .DS_Store
     if (!/^\..*/.test(name)) {
@@ -316,6 +320,8 @@ module.exports = function (context) {
             if (productName.indexOf('ShareExt') >= 0) {
               buildSettingsObj['PROVISIONING_PROFILE'] = PROVISIONING_PROFILE;
               buildSettingsObj['DEVELOPMENT_TEAM'] = DEVELOPMENT_TEAM;
+              buildSettingsObj['CODE_SIGN_STYLE'] = 'Manual';
+              buildSettingsObj['CODE_SIGN_IDENTITY'] = '"iPhone Distribution"';
               console.log('Added signing identities for extension!');
             }
           }

diff --git a/plugin.xml b/plugin.xml
@@ -75,6 +75,7 @@ SOFTWARE.
         </config-file>
 
         <hook type="before_plugin_install" src="hooks/npmInstall.js" />
+        <hook type="after_plugin_install" src="hooks/iosCopyShareExtension.js" />
         <hook type="before_prepare" src="hooks/iosCopyShareExtension.js" />
         <hook type="after_prepare" src="hooks/iosAddTarget.js" />
         <hook type="before_plugin_uninstall" src="hooks/iosRemoveTarget.js" />