-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support docker language #67
Conversation
Thanks for your fantastic work! I'll review it soon! |
@j178 I want to rewrite all commands to this crate https://github.com/fussybeaver/bollard , so maybe late review /= =/ |
@bxb100 I would prefer using the Docker CLI because it is lightweight and doesn't require many dependencies for basic Docker operations, unlike |
@j178 Ok |
Thanks for your fantastic work here! I'm planning to make some adjustments to the coding style, hope you don't mind. Also, I'm considering simplifying the Docker test by removing the inner Docker test. It seems unnecessary to add a complex test job just for that. |
The |
I considered this and added a maybe we can preserve it and add |
I plan to modify |
(I'll handle the conflicts with master) |
Thanks for your patience, let's merge! |
close: #49
TODO
Footnotes
https://github.com/actions/runner-images/issues/17 ↩
https://github.com/orgs/community/discussions/21317 ↩