Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Query Display to Split Pane, query box now remembers last expression #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Avinm
Copy link

@Avinm Avinm commented May 27, 2018

No description provided.

@j--wong
Copy link
Owner

j--wong commented Apr 27, 2019

Hi @Avinm, thanks for the PR. I do have plans to introduce split pane for displaying results. If you're still interested in getting your PR merged, would you mind creating a separate ResultViewer such as SplitPanelResultViewer instead of modifying the OutputChannelResultViewer? That way, we can later have config to allow user to switch between them? Also, please add unit tests for the new result viewer implementation. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants